Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5147)

Unified Diff: chrome/browser/unload_uitest.cc

Issue 114063: Disable the failing UI test. I filed a P1 bug on it. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/unload_uitest.cc
===================================================================
--- chrome/browser/unload_uitest.cc (revision 17041)
+++ chrome/browser/unload_uitest.cc (working copy)
@@ -327,6 +327,10 @@
L"twosecondbeforeunloadalert");
}
+// TODO(brettw) bug 12913 this test was broken by WebKit merge 42202:44252.
+// Apparently popup titles are broken somehow.
+#if 0
+
// Tests that if there's a renderer process with two tabs, one of which has an
// unload handler, and the other doesn't, the tab that doesn't have an unload
// handler can be closed. If this test fails, the Close() call will hang.
@@ -362,5 +366,7 @@
EXPECT_EQ(std::wstring(L"only_one_unload"), main_title);
}
+#endif
+
// TODO(ojan): Add tests for unload/beforeunload that have multiple tabs
// and multiple windows.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698