Issue 114058: Pressing "enter" while the JS prompt text entry has focus should

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114058: Pressing "enter" while the JS prompt text entry has focus should (Closed)

Created:
11 years, 6 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Pressing "enter" while the JS prompt text entry has focus should accept the user's text.

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/app_modal_dialog_gtk.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Evan Martin

http://library.gnome.org/devel/gtk/unstable/GtkEntry.html#gtk-entry-set-activates-default

11 years, 6 months ago (2009-05-29 00:09:08 UTC) #2

tony

On 2009/05/29 00:09:08, Evan Martin wrote: > http://library.gnome.org/devel/gtk/unstable/GtkEntry.html#gtk-entry-set-activates-default Done.

11 years, 6 months ago (2009-05-29 00:15:56 UTC) #3

Sorry to make your patch tiny :~(

LGTM