Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 114047: Add import progress indicator dialog. (Closed)

Created:
11 years, 7 months ago by kuchhal
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make the import feature a little more complete: - Now we show import progress of individual items - In case Firefox is running we display a warning and allow user to close it before proceeding - Delete the Firefox lock when import finishes BUG=11191

Patch Set 1 #

Total comments: 7

Patch Set 2 : code review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -60 lines) Patch
M chrome/browser/gtk/import_dialog_gtk.h View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/gtk/import_dialog_gtk.cc View 1 5 chunks +23 lines, -17 lines 0 comments Download
A chrome/browser/gtk/import_lock_dialog_gtk.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/gtk/import_lock_dialog_gtk.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/gtk/import_progress_dialog_gtk.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/gtk/import_progress_dialog_gtk.cc View 1 chunk +202 lines, -0 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 1 3 chunks +21 lines, -31 lines 0 comments Download
M chrome/browser/importer/firefox_profile_lock_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/importer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/importer.cc View 1 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kuchhal
11 years, 7 months ago (2009-05-22 22:21:02 UTC) #1
Evan Martin
http://codereview.chromium.org/114047/diff/1/2 File chrome/browser/gtk/import_dialog_gtk.cc (right): http://codereview.chromium.org/114047/diff/1/2#newcode35 Line 35: GTK_RESPONSE_ACCEPT, This should stay in its original position, ...
11 years, 7 months ago (2009-05-22 22:37:35 UTC) #2
kuchhal
Two comments below. Everything else fixed. Please take another look. http://codereview.chromium.org/114047/diff/1/6 File chrome/browser/gtk/import_progress_dialog_gtk.cc (right): http://codereview.chromium.org/114047/diff/1/6#newcode181 ...
11 years, 7 months ago (2009-05-26 19:06:14 UTC) #3
Evan Martin
11 years, 7 months ago (2009-05-26 22:32:12 UTC) #4
OK, LG

Powered by Google App Engine
This is Rietveld 408576698