Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 11404: Add experimental support for external two-byte symbols.... (Closed)

Created:
12 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Add experimental support for external two-byte symbols. This might be a big win in a browser setting where a lot of string conversions can be avoided. On the other hand it adds extra pressure on the global handle system. Committed: http://code.google.com/p/v8/source/detail?r=772

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -14 lines) Patch
M include/v8.h View 3 chunks +31 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap.h View 4 chunks +20 lines, -3 lines 0 comments Download
M src/heap.cc View 4 chunks +64 lines, -3 lines 0 comments Download
M src/heap-inl.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
12 years, 1 month ago (2008-11-17 14:52:49 UTC) #1
Kasper Lund
12 years, 1 month ago (2008-11-17 15:06:58 UTC) #2
LGTM, but you should document that you're passing UTF8 data to the callback
function somewhere.

Powered by Google App Engine
This is Rietveld 408576698