Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 114024: Avoid linear search for non-locals in the scope code... (Closed)

Created:
11 years, 7 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid linear search for non-locals in the scope code when resolving variables inside with and eval scopes. Committed: http://code.google.com/p/v8/source/detail?r=1937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M src/scopes.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/scopes.cc View 6 chunks +37 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kasper Lund
11 years, 7 months ago (2009-05-13 16:18:22 UTC) #1
Mads Ager (chromium)
LGTM
11 years, 7 months ago (2009-05-13 16:24:39 UTC) #2
Kevin Millikin (Chromium)
11 years, 7 months ago (2009-05-13 16:26:53 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698