Issue 114018: Simplify JumpTarget::ComputeEntryFrame. Eliminate a separate pass...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114018: Simplify JumpTarget::ComputeEntryFrame. Eliminate a separate pass... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify JumpTarget::ComputeEntryFrame. Eliminate a separate pass over the frame elements to find registers used (before allocating undetermined elements) and another pass to set the frame's register indices (after allocating all elements). Committed: http://code.google.com/p/v8/source/detail?r=1906

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -27 lines)			Patch
M	src/arm/register-allocator-arm.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/register-allocator-ia32.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/jump-target.cc	View	4 chunks	+30 lines, -27 lines	2 comments	Download
M	src/register-allocator.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/114018/diff/1/4 File src/jump-target.cc (right): http://codereview.chromium.org/114018/diff/1/4#newcode194 Line 194: // address). Fill those in first. The ...

11 years, 7 months ago (2009-05-11 13:47:34 UTC) #2

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-11 13:57:15 UTC) #3

http://codereview.chromium.org/114018/diff/1/4
File src/jump-target.cc (right):

http://codereview.chromium.org/114018/diff/1/4#newcode194
Line 194: // address).  Fill those in first.
Replaced with:
  // Build the new frame.  A freshly allocated frame has memory elements
  // for the parameters and some platform-dependent elements (e.g.,
  // return address).  Replace those first.

Expand Messages | Collapse Messages