 Chromium Code Reviews
 Chromium Code Reviews Issue 114010:
  X64: Changed 0x%x formats in log.cc to 0x%p and omitted reinterpretting pointers.  (Closed)
    
  
    Issue 114010:
  X64: Changed 0x%x formats in log.cc to 0x%p and omitted reinterpretting pointers.  (Closed) 
  | Index: src/globals.h | 
| diff --git a/src/globals.h b/src/globals.h | 
| index d4f4eee21e67cc4824a13dcb408ae1a9ca66367d..6718c104caaa55cb617afe6643a1b1568613db2d 100644 | 
| --- a/src/globals.h | 
| +++ b/src/globals.h | 
| @@ -76,11 +76,17 @@ typedef byte* Address; | 
| #ifdef _MSC_VER | 
| #define V8_UINT64_C(x) (x ## UI64) | 
| #define V8_INT64_C(x) (x ## I64) | 
| +#define V8_PTR_PREFIX "ll" | 
| #else | 
| #define V8_UINT64_C(x) (x ## UL) | 
| #define V8_INT64_C(x) (x ## L) | 
| +#define V8_PTR_PREFIX "l" | 
| #endif | 
| -#endif // V8_HOST_ARCH_64_BIT | 
| +#else // V8_HOST_ARCH_64_BIT | 
| +#define V8_PTR_PREFIX "" | 
| +#endif | 
| + | 
| +#define V8PRIp V8_PTR_PREFIX "x" | 
| 
William Hesse
2009/05/07 09:42:11
why not #define V8_PTR_FORMAT "0x%llx"
etc. for al
 
Erik Corry
2009/05/07 09:58:58
Certainly prefix is the wrong name; since it goes
 | 
| // Code-point values in Unicode 4.0 are 21 bits wide. | 
| typedef uint16_t uc16; |