Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: src/log.h

Issue 114010: X64: Changed 0x%x formats in log.cc to 0x%p and omitted reinterpretting pointers. (Closed)
Patch Set: Forgot "%" before format constant.wq Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/globals.h ('K') | « src/globals.h ('k') | src/log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 friend class VMState; 254 friend class VMState;
255 #else 255 #else
256 static bool is_enabled() { return false; } 256 static bool is_enabled() { return false; }
257 #endif 257 #endif
258 }; 258 };
259 259
260 260
261 // Class that extracts stack trace, used for profiling. 261 // Class that extracts stack trace, used for profiling.
262 class StackTracer BASE_EMBEDDED { 262 class StackTracer BASE_EMBEDDED {
263 public: 263 public:
264 explicit StackTracer(unsigned int low_stack_bound) 264 explicit StackTracer(uintptr_t low_stack_bound)
265 : low_stack_bound_(low_stack_bound) { } 265 : low_stack_bound_(low_stack_bound) { }
266 void Trace(TickSample* sample); 266 void Trace(TickSample* sample);
267 private: 267 private:
268 268
269 unsigned int low_stack_bound_; 269 uintptr_t low_stack_bound_;
270 }; 270 };
271 271
272 272
273 } } // namespace v8::internal 273 } } // namespace v8::internal
274 274
275 #endif // V8_LOG_H_ 275 #endif // V8_LOG_H_
OLDNEW
« src/globals.h ('K') | « src/globals.h ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698