X64: Changed 0x%x formats in log.cc to 0x%p and omitted reinterpretting pointers.

src/globals.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 58 matching lines @@
 typedef uint8_t byte;
 typedef byte* Address;
 
 // Define our own macros for writing 64-bit constants.  This is less fragile
 // than defining __STDC_CONSTANT_MACROS before including <stdint.h>, and it
 // works on compilers that don't have it (like MSVC).
 #if V8_HOST_ARCH_64_BIT
 #ifdef _MSC_VER
 #define V8_UINT64_C(x)  (x ## UI64)
 #define V8_INT64_C(x)   (x ## I64)
+#define V8_PTR_PREFIX "ll"
 #else
 #define V8_UINT64_C(x)  (x ## UL)
 #define V8_INT64_C(x)   (x ## L)
+#define V8_PTR_PREFIX "l"
 #endif
-#endif  // V8_HOST_ARCH_64_BIT
+#else // V8_HOST_ARCH_64_BIT
+#define V8_PTR_PREFIX ""
+#endif
+
+#define V8PRIp V8_PTR_PREFIX "x"

[William Hesse, 2009/05/07 09:42:11]

why not #define V8_PTR_FORMAT "0x%llx"
etc. for all the cases, then
printf("My pointer: "V8_PTR_FORMAT
       " it is easy to break lines here too.", ptr);

I guess you need to break out of quotes for the macro to apply, or don't you? 
If not, I wouldn't include the quotes.

[Erik Corry, 2009/05/07 09:58:58]

Certainly prefix is the wrong name; since it goes after the '%' it must be a
suffix.

 
 // Code-point values in Unicode 4.0 are 21 bits wide.
 typedef uint16_t uc16;
 typedef int32_t uc32;
 
 // -----------------------------------------------------------------------------
 // Constants
 
 const int KB = 1024;
 const int MB = KB * KB;
@@ skipping 434 matching lines @@
 
   Dest dest;
   memcpy(&dest, &source, sizeof(dest));
   return dest;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_GLOBALS_H_