Issue 114007: linux: gyp should fail if the build dependencies aren't met.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114007: linux: gyp should fail if the build dependencies aren't met. (Closed)

Created:
11 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: gyp should fail if the build dependencies aren't met. The alternative is that gyp silently succeeds and your build mysteriously doesn't link, even after you've installed the dependencies, and you need to know to rerun "gclient runhooks --force". BUG=11432

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -54 lines)			Patch
	M	build/linux/pkg_config_wrapper.py	View		1 chunk	+0 lines, -30 lines	0 comments	Download
	M	build/linux/system.gyp	View		8 chunks	+24 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages