Issue 1140004: MIPS simple function calls...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1140004: MIPS simple function calls... (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev, Alexandre

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

MIPS simple function calls This lands http://codereview.chromium.org/1018001. Patch by Alexandre Rames <alexandre.rames@gmail.com>; from Sigma Designs Inc. Mads, please just have to look at the new flag --disable-native-files (two files not in the mips directory). Committed: http://code.google.com/p/v8/source/detail?r=4234

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2049 lines, -165 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/builtins-mips.cc	View		2 chunks	+94 lines, -1 line	0 comments	Download
M	src/mips/codegen-mips.h	View		5 chunks	+115 lines, -4 lines	0 comments	Download
M	src/mips/codegen-mips.cc	View		14 chunks	+906 lines, -47 lines	0 comments	Download
M	src/mips/codegen-mips-inl.h	View		1 chunk	+25 lines, -1 line	0 comments	Download
M	src/mips/frames-mips.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/frames-mips.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/mips/ic-mips.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	src/mips/jump-target-mips.cc	View		3 chunks	+88 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View		9 chunks	+86 lines, -9 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View		22 chunks	+438 lines, -27 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View		2 chunks	+45 lines, -2 lines	0 comments	Download
M	src/mips/virtual-frame-mips.h	View		22 chunks	+43 lines, -46 lines	0 comments	Download
M	src/mips/virtual-frame-mips.cc	View		7 chunks	+104 lines, -18 lines	0 comments	Download
M	test/cctest/SConscript	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-assembler-mips.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/cctest/test-mips.cc	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 9 months ago (2010-03-23 15:02:51 UTC) #2

LGTM.  The flag looks fine and is needed when working on a new port.

Expand Messages | Collapse Messages