Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5510)

Unified Diff: chrome/chrome.gyp

Issue 113999: Run real dsymutil to get a real .dSYM for Breakpad dump_syms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 17113)
+++ chrome/chrome.gyp (working copy)
@@ -2132,6 +2132,10 @@
}],
['mac_breakpad==1', {
# Only include breakpad in official builds.
+ 'variables': {
+ # A real .dSYM is needed for dump_syms to operate on.
+ 'mac_real_dsym': 1,
+ },
'dependencies': [
'../breakpad/breakpad.gyp:breakpad',
'../breakpad/breakpad.gyp:dump_syms',
@@ -2143,22 +2147,14 @@
'files': ['<(PRODUCT_DIR)/crash_inspector', '<(PRODUCT_DIR)/crash_report_sender.app'],
},
],
- 'target_conditions': [
- # We use target_conditions here that is always true to force
- # this post build to run last. This lets the strip from
- # common.gypi go ahead of it, so we can always hit the
- # upstripped app within the fake dSYM.
- ['1', {
- 'postbuilds': [
- {
- 'postbuild_name': 'Dump Symbols',
- 'action': ['<(DEPTH)/build/mac/dump_app_syms',
- '<(branding)'],
- },
- ],
- }],
+ 'postbuilds': [
+ {
+ 'postbuild_name': 'Dump Symbols',
+ 'action': ['<(DEPTH)/build/mac/dump_app_syms',
+ '<(branding)'],
+ },
],
- }], # mac_breakpad
+ }], # mac_breakpad
['mac_keystone==1', {
'copies': [
{
@@ -2166,7 +2162,7 @@
'files': ['../third_party/googlemac/Releases/Keystone/KeystoneRegistration.framework'],
},
],
- }], # mac_keystone
+ }], # mac_keystone
],
'product_name': '<(mac_product_name)',
'xcode_settings': {
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698