Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 113992: fix embedded vector copy constructor and assignment. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

fix embedded vector copy constructor and assignment. Thanks to Tobias Kaes, an issue with default copy constructor and assignment operator is found and fixed. BUG=http://code.google.com/p/v8/issues/detail?id=358 Committed: http://code.google.com/p/v8/source/detail?r=2077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M src/utils.h View 2 chunks +19 lines, -0 lines 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-05-29 08:31:03 UTC) #1
Søren Thygesen Gjesse
11 years, 6 months ago (2009-05-29 08:58:46 UTC) #2
LGTM!

Great to get this fixed!

Powered by Google App Engine
This is Rietveld 408576698