Issue 113984: A bit more clean up for Linux upload crash dump....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113984: A bit more clean up for Linux upload crash dump.... (Closed)

Created:
11 years, 7 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

A bit more clean up for Linux upload crash dump. BUG=none TEST=visit about:crash, no dump file left over in /tmp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17161

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/app/breakpad_linux.cc	View	1 2	1 chunk	+9 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

I still get garbage in the case where I chmod 0 wget. sys_unlink(buf) didn't make ...

11 years, 7 months ago (2009-05-29 02:25:10 UTC) #1

agl

11 years, 7 months ago (2009-05-29 02:36:11 UTC) #2

Damm, yea. Good catch. Thanks.

LGTM.

Are you still seeing crashing in the handler for browser crashes?