Major refactoring of Croc....

Major refactoring of Croc.

Add support for scanning missing source files for executable lines.
Add support for HTML output.
Now reports percent coverage.

BUG=none
TEST=by hand on experimental buildbot

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17141

[bradn, 2009-05-28 23:57:36]

LGTM, generally. How portable is it?

http://codereview.chromium.org/113980/diff/1/6
File tools/code_coverage/croc_scan.py (right):

http://codereview.chromium.org/113980/diff/1/6#newcode151
Line 151: # TODO: Do Objective C and C++ follow the same comment patterns as C /
C++?
Yes.

http://codereview.chromium.org/113980/diff/1/8
File tools/code_coverage/croc_test.py (right):

http://codereview.chromium.org/113980/diff/1/8#newcode418
Line 418: 'SF:c:\\source\\c.c',
Does this test work on non-windows?

[Randall Spangler, 2009-05-29 00:02:57]

http://codereview.chromium.org/113980/diff/1/8
File tools/code_coverage/croc_test.py (right):

http://codereview.chromium.org/113980/diff/1/8#newcode418
Line 418: 'SF:c:\\source\\c.c',
On 2009/05/28 23:57:36, bradn wrote:
> Does this test work on non-windows?

Yep.

[John Grabowski, 2009-05-29 00:34:43]

http://codereview.chromium.org/113980/diff/1/4
File build/common.croc (right):

http://codereview.chromium.org/113980/diff/1/4#newcode1
Line 1: # -*- python -*-
Need standard Chromium copyright here.  By analogy, chrome.gyp has one.

http://codereview.chromium.org/113980/diff/1/4#newcode65
Line 65: 'format' : '*RESULT FilesInstrumentedPercent:
files_instrumented_percent= %g',
>80

http://codereview.chromium.org/113980/diff/1/3
File build/mac/chrome_mac.croc (right):

http://codereview.chromium.org/113980/diff/1/3#newcode13
Line 13: # Don't include subversion or mercurial SCM dirs
Seems a few more rules here (no svn, output dirs, third-party) should be moved
into the common croc.

http://codereview.chromium.org/113980/diff/1/7
File tools/code_coverage/croc_html.py (right):

http://codereview.chromium.org/113980/diff/1/7#newcode1
Line 1: #!/usr/bin/python2.4
/usr/bin/env python?
Non-Google machines won't necessarily have py2.4

http://codereview.chromium.org/113980/diff/1/7#newcode3
Line 3: # Copyright 2009, Google Inc.
(c) the Chromium authors?

http://codereview.chromium.org/113980/diff/1/6
File tools/code_coverage/croc_scan.py (right):

http://codereview.chromium.org/113980/diff/1/6#newcode1
Line 1: #!/usr/bin/python2.4
Ditto comments form other files (py2.4, copyright)

http://codereview.chromium.org/113980/diff/1/6#newcode32
Line 32: """Crocodile source scanners."""
Elaborate a little.  Why is a scanner useful?  What does it get me?

http://codereview.chromium.org/113980/diff/1/6#newcode143
Line 143: self.re_token = re.compile(r'(#|\'\'\'|"""|(?<!(?<!\\)\\)["\'])')
Comments around regexps explaing what they are supposed to match are helpful. 
Ditto other places in this file.