Lazily create the clipboard owner window. CreateWindow can take ~.5ms, and w...

Lazily create the clipboard owner window.  CreateWindow can take ~.5ms, and we don't need to do this until the clipboard is actually used (ctrl-c/ctrl-v).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5963

[Dean McNamee, 2008-11-24 16:45:43]

I'm not super into sprinkling EnsureClipboardWindow everywhere, but, yeah,
whatevz.

[sky, 2008-11-24 17:02:37]

LGTM

http://codereview.chromium.org/11398/diff/201/6
File base/clipboard_win.cc (right):

http://codereview.chromium.org/11398/diff/201/6#newcode622
Line 622: };
nit: no ;

[Dean McNamee, 2008-11-24 22:49:03]

Updated because I had to remove a bunch of const-ness.  Adding Tony.

On 2008/11/24 17:02:37, sky wrote:
> LGTM
> 
> http://codereview.chromium.org/11398/diff/201/6
> File base/clipboard_win.cc (right):
> 
> http://codereview.chromium.org/11398/diff/201/6#newcode622
> Line 622: };
> nit: no ;

[Peter Kasting, 2008-11-24 22:51:30]

On 2008/11/24 22:49:03, Dean McNamee wrote:
> Updated because I had to remove a bunch of const-ness.

Don't remove const from all these; they're still logically const.  Just make the
underlying window member mutable.

[Dean McNamee, 2008-11-25 00:53:59]

Updated w/ mutable.

On 2008/11/24 22:51:30, pkasting wrote:
> On 2008/11/24 22:49:03, Dean McNamee wrote:
> > Updated because I had to remove a bunch of const-ness.
> 
> Don't remove const from all these; they're still logically const.  Just make
the
> underlying window member mutable.

[Peter Kasting, 2008-11-25 00:55:01]

LGTM!

[Peter Kasting, 2008-11-25 00:57:08]

On 2008/11/25 00:55:01, pkasting wrote:
> LGTM!

BTW, another technique that would have worked here is changing direct accesses
to clipboard_owner_ into calls to a getter function which itself ensured the
window was created.  This might be a bit safer in terms of future coders, who
don't have to remember to add EnsureClipboardWindow() or wonder whether a
function really needs it, but the difference is pretty slight, so it's totally
up to you whether you think this really buys much.

[Dean McNamee, 2008-11-25 01:35:46]

Ok, one last time then.

On 2008/11/25 00:57:08, pkasting wrote:
> On 2008/11/25 00:55:01, pkasting wrote:
> > LGTM!
> 
> BTW, another technique that would have worked here is changing direct accesses
> to clipboard_owner_ into calls to a getter function which itself ensured the
> window was created.  This might be a bit safer in terms of future coders, who
> don't have to remember to add EnsureClipboardWindow() or wonder whether a
> function really needs it, but the difference is pretty slight, so it's totally
> up to you whether you think this really buys much.

[Peter Kasting, 2008-11-25 06:46:13]

LGTM again with nit

http://codereview.chromium.org/11398/diff/22/219
File base/clipboard.h (right):

http://codereview.chromium.org/11398/diff/22/219#newcode182
Line 182: // Mark this as mutable so const methods can still do lazy
initialization.
Nit: Should probably comment that no one should access this directly (unless
they don't want to create it, like the destructor).

Also probably don't need the explanation on mutable, it's sort of obvious, but
feel free to leave it if you think it adds clarity