linux: wrap prefs checkbox in options window.

linux: wrap prefs checkbox in options window.

This is a quick hack, that will be replaced once we have the rest of prefs
implemented.

BUG=12736

[Evan Stade, 2009-05-28 23:58:38]

http://codereview.chromium.org/113977/diff/1/2
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/113977/diff/1/2#newcode125
Line 125: GtkWidget* label = gtk_label_new(
|metrics_label| perhaps

http://codereview.chromium.org/113977/diff/1/2#newcode129
Line 129: gtk_widget_set_size_request(label, 475, -1);
won't this make it unreadable if you have a WM that ignores the minimum size?
Probably better to just get rid of this line. But then again that will make it
wrap at a strange place usually. 

Firefox's pref menu seems to do it right (if you change the size of the windows
the line wrap point changes) so it must be possible.

[Evan Martin, 2009-05-29 00:02:56]

http://codereview.chromium.org/113977/diff/1/2
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/113977/diff/1/2#newcode125
Line 125: GtkWidget* label = gtk_label_new(
On 2009/05/28 23:58:39, Evan Stade wrote:
> |metrics_label| perhaps

Done.

http://codereview.chromium.org/113977/diff/1/2#newcode129
Line 129: gtk_widget_set_size_request(label, 475, -1);
On 2009/05/28 23:58:39, Evan Stade wrote:
> won't this make it unreadable if you have a WM that ignores the minimum size?
> Probably better to just get rid of this line. But then again that will make it
> wrap at a strange place usually. 

This is the size "request", not allocate, so I think it will work if it's
forcefully sized smaller.

GTK labels don't wrap unless you explicitly set a max width on them.  :\ 
Officially, you're not supposed to use multiline labels for things like check
boxes.

> Firefox's pref menu seems to do it right (if you change the size of the
windows
> the line wrap point changes) so it must be possible.

They work like views -- they draw and then try to look like GTK.

[Evan Stade, 2009-05-29 00:15:23]

We can revisit this later, when we fill out the rest of the options input. For
now this LGTM.

http://codereview.chromium.org/113977/diff/1/2
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/113977/diff/1/2#newcode129
Line 129: gtk_widget_set_size_request(label, 475, -1);
> > won't this make it unreadable if you have a WM that ignores the minimum
size?

sorry, I shouldn't have posed this as a question. I tested, and it does make it
unreadable.

> GTK labels don't wrap unless you explicitly set a max width on them.

In my test, it did wrap without setting an explicit max length, but it wrapped
way early and ended up with 2 approximately even length lines.