Issue 113974: Fix branded resource buiding....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113974: Fix branded resource buiding.... (Closed)

Created:
11 years, 7 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, bradnelson, M-A Ruel

CC:
chromium-reviews_googlegroups.com, jon, mikesmith_chromium.org, pink (ping after 24hrs), Amanda Walker

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix branded resource buiding. One visible change: new tab page has Google icon, not Chromium. Gyp doesn't have a set environment variable facility; hence the addition of a command line option to grit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17148

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/chrome.gyp	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	tools/grit/grit/tool/build.py	View		3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM from anyone on To: is fine.

Expand Messages | Collapse Messages