Issue 113970: Paint a focus indication on LinkButtonGtk buttons....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113970: Paint a focus indication on LinkButtonGtk buttons.... (Closed)

Created:
11 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Paint a focus indication on LinkButtonGtk buttons. Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space. Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton). BUG=12829 TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17132

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -49 lines)			Patch
M	chrome/browser/gtk/custom_button.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.cc	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/gtk/download_item_gtk.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/gtk/download_shelf_gtk.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/find_bar_gtk.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_button.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/infobar_gtk.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/gtk/link_button_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/link_button_gtk.cc	View	1 chunk	+15 lines, -8 lines	0 comments	Download
M	chrome/common/gtk_util.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
	chrome/common/gtk_util.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 7 months ago (2009-05-29 09:58:05 UTC) #3

On 2009/05/28 23:16:49, Elliot Glaysher wrote:
> LGTM

Didn't this totally regress find bar?  The close button is on the left side now,
and the padding is totally crazy.  Make sure to keep it pixel perfect with
Windows, I tried so hard! :)

Thanks

Expand Messages | Collapse Messages