Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 113968: Add code to handle errors in .gclient configuration files (Closed)

Created:
11 years, 7 months ago by SkyLined
Modified:
9 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add code to handle errors in .gclient configuration files and output human readble information rather than a raw exception stack. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17179

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M gclient.py View 1 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
SkyLined
This should make life a bit easier for people who edit their .gclient files but ...
11 years, 7 months ago (2009-05-28 21:16:20 UTC) #1
M-A Ruel
http://codereview.chromium.org/113968/diff/1/2 File gclient.py (right): http://codereview.chromium.org/113968/diff/1/2#newcode957 Line 957: for line in error_message: You can just `raise ...
11 years, 7 months ago (2009-05-28 21:22:13 UTC) #2
SkyLined
> You can just `raise Error(error_message)` instead, it's already taken care of in > the ...
11 years, 7 months ago (2009-05-28 21:29:36 UTC) #3
M-A Ruel
11 years, 7 months ago (2009-05-28 22:24:39 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698