Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 113967: Add general options page. Options are working with the following exceptions: (Closed)

Created:
11 years, 7 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add general options page. Options are working with the following exceptions: Custom start urls and default search options widgets aren't hooked up. Home page settings work, but are overridden by the linux start page settings. Default browser checking/setting functions are not implemented, so the option isn't useful yet. Refactors some common code out of browser/views/options/options_page_view.* into browser/options_page_base.{cc,h} BUG=11507 Patch by Matt Mueller (mattm@google.com).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+726 lines, -48 lines) Patch
M app/l10n_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M app/l10n_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browser.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/gtk/options/general_page_gtk.h View 1 chunk +106 lines, -0 lines 0 comments Download
A chrome/browser/gtk/options/general_page_gtk.cc View 1 chunk +415 lines, -0 lines 0 comments Download
A chrome/browser/gtk/options/options_layout_gtk.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/gtk/options/options_layout_gtk.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/gtk/options/options_window_gtk.cc View 4 chunks +6 lines, -2 lines 0 comments Download
A chrome/browser/options_page_base.h View 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/browser/options_page_base.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/views/options/options_page_view.h View 3 chunks +2 lines, -28 lines 0 comments Download
M chrome/browser/views/options/options_page_view.cc View 1 chunk +1 line, -18 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +6 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698