Issue 113964: Make AffectedFile member variables private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113964: Make AffectedFile member variables private. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make AffectedFile member variables private. Cache SvnAffectedFile.IsTextFile() return value. Improve the unit test by not/less relying on the local file system.

Patch Set 2 : Improved the unit tests #

Patch Set 3 : 80cols #

Total comments: 3

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -39 lines)			Patch
	M	presubmit_support.py	View	1	3 chunks	+41 lines, -33 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View	1 2	12 chunks	+60 lines, -6 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

LGTM with nits http://codereview.chromium.org/113964/diff/3001/3003 File tests/presubmit_unittest.py (right): http://codereview.chromium.org/113964/diff/3001/3003#newcode698 Line 698: self.failIf(affected_file.IsDirectory()) duplicate? http://codereview.chromium.org/113964/diff/3001/3003#newcode708 Line 708: ...

11 years, 6 months ago (2009-05-28 21:30:51 UTC) #2

M-A Ruel

http://codereview.chromium.org/113964/diff/3001/3003 File tests/presubmit_unittest.py (right): http://codereview.chromium.org/113964/diff/3001/3003#newcode698 Line 698: self.failIf(affected_file.IsDirectory()) On 2009/05/28 21:30:51, Jói wrote: > duplicate? ...

11 years, 6 months ago (2009-05-29 00:59:55 UTC) #3

LGTM