Issue 113960: Handle opening URLs when there is no window open....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113960: Handle opening URLs when there is no window open.... (Closed)

Created:
11 years, 6 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Handle opening URLs when there is no window open. BUG=http://crbug.com/12550 TEST=as described in bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17097

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/app_controller_mac.mm	View		1 chunk	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

We don't have a fully-initialized BrowserInit here, and since we'd need to handle things more ...

11 years, 6 months ago (2009-05-28 19:28:31 UTC) #1

Scott Hess - ex-Googler

LGTM. http://codereview.chromium.org/113960/diff/1/2 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/113960/diff/1/2#newcode360 Line 360: browser->window()->Show(); Does the Show() at this point ...

11 years, 6 months ago (2009-05-28 19:34:22 UTC) #2

Avi (use Gerrit)

On 2009/05/28 19:34:22, shess wrote: > Does the Show() at this point cause any jankiness? ...

11 years, 6 months ago (2009-05-28 19:35:34 UTC) #3

Still LGTM.

Expand Messages | Collapse Messages