Issue 113954: Refactors drag_utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113954: Refactors drag_utils. (Closed)

Created:
11 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactors drag_utils. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17080

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -162 lines)			Patch
M	views/drag_utils.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	views/drag_utils.cc	View	4 chunks	+7 lines, -74 lines	0 comments	Download
A	views/drag_utils_gtk.cc	View	1 chunk	+22 lines, -0 lines	1 comment	Download
A +	views/drag_utils_win.cc	View	2 chunks	+1 line, -82 lines	0 comments	Download
M	views/views.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 7 months ago (2009-05-28 16:59:14 UTC) #2

LGTM

http://codereview.chromium.org/113954/diff/1/6
File views/drag_utils_gtk.cc (right):

http://codereview.chromium.org/113954/diff/1/6#newcode22
Line 22: } // namespace drag_utils
You need an extra space before the //

Expand Messages | Collapse Messages