Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Side by Side Diff: webkit/glue/devtools/js/inject_dispatch.js

Issue 113953: DevTools: Add support for non-trivial console messages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Injects 'injected' object into the inspectable page. 6 * @fileoverview Injects 'injected' object into the inspectable page.
7 */ 7 */
8 8
9 /** 9 /**
10 * Dispatches host calls into the injected function calls. 10 * Dispatches host calls into the injected function calls.
(...skipping 22 matching lines...) Expand all
33 }; 33 };
34 34
35 35
36 /** 36 /**
37 * This is called by the InspectorFrontend for serialization. 37 * This is called by the InspectorFrontend for serialization.
38 * We serialize the call and send it to the client over the IPC 38 * We serialize the call and send it to the client over the IPC
39 * using dispatchOut bound method. 39 * using dispatchOut bound method.
40 */ 40 */
41 var dispatch = function(method, var_args) { 41 var dispatch = function(method, var_args) {
42 // Handle all messages with non-primitieve arguments here. 42 // Handle all messages with non-primitieve arguments here.
43 // TODO(pfeldman): Add more.
44 if (method == 'inspectedWindowCleared') { 43 if (method == 'inspectedWindowCleared') {
45 return; 44 return;
46 } 45 }
47 var call = JSON.stringify(Array.prototype.slice.call(arguments)); 46 var args = Array.prototype.slice.call(arguments);
yurys 2009/05/28 16:28:04 you can move this in the 'if' block below
47
48 // Serialize objects here.
49 if (method == 'addMessageToConsole') {
50 // Skip first argument since it is serializable.
51 for (var i = 1; i < args.length; ++i) {
52 var type = typeof args[i];
53 if (type == 'object') {
54 args[i] = Object.prototype.toString(args[i]);
55 } else if (type == 'function') {
56 args[i] = args[i].toString();
57 }
58 }
59 }
60 var call = JSON.stringify(args);
48 RemoteWebInspector.dispatch(call); 61 RemoteWebInspector.dispatch(call);
49 }; 62 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698