Separate results of profiling sessions....

webkit/glue/devtools/js/debugger_agent.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Provides communication interface to remote v8 debugger. See
  * protocol decription at http://code.google.com/p/v8/wiki/DebuggerProtocol
  */
 goog.provide('devtools.DebuggerAgent');
 
@@ skipping 51 matching lines @@
    */
   this.requestSeqToCallback_ = null;
 
   /**
    * Whether the scripts list has been requested.
    * @type {boolean}
    */
   this.scriptsCacheInitialized_ = false;
 
   /**
-   * Whether user has stopped profiling and we are retrieving the rest of
-   * profiler's log.
+   * Whether profiling session is started.
    * @type {boolean}
    */
-  this.isProcessingProfile_ = false;
+  this.isProfilingStarted_ = false;
 
   /**
    * The position in log file to read from.
    * @type {number}
    */
   this.lastProfileLogPosition_ = 0;
 
   /**
    * Profiler processor instance.
    * @type {devtools.profiler.Processor}
    */
-  this.profilerProcessor_ = new devtools.profiler.Processor();
+  this.profilerProcessor_ = new devtools.profiler.Processor(
+      goog.bind(WebInspector.addProfile, WebInspector));
 };
 
 
 /**
  * Resets debugger agent to its initial state.
  */
 devtools.DebuggerAgent.prototype.reset = function() {
   this.scriptsCacheInitialized_ = false;
   this.contextId_ = null;
   this.parsedScripts_ = {};
@@ skipping 242 matching lines @@
     }
     callback(object);
   }
 };
 
 
 /**
  * Starts (resumes) profiling.
  */
 devtools.DebuggerAgent.prototype.startProfiling = function() {
-  if (this.isProcessingProfile_) {
-    return;
-  }
   RemoteDebuggerAgent.StartProfiling();
-  // Query if profiling has been really started.
   RemoteDebuggerAgent.IsProfilingStarted();
 };
 
 
 /**
  * Stops (pauses) profiling.
  */
 devtools.DebuggerAgent.prototype.stopProfiling = function() {
-  this.isProcessingProfile_ = true;
   RemoteDebuggerAgent.StopProfiling();
 };
 
 
 /**
  * Removes specified breakpoint from the v8 debugger.
  * @param {number} breakpointId Id of the breakpoint in the v8 debugger.
  */
 devtools.DebuggerAgent.prototype.requestClearBreakpoint_ = function(
     breakpointId) {
@@ skipping 231 matching lines @@
   }
   this.addScriptInfo_(script);
 };
 
 
 /**
  * Handles current profiler status.
  */
 devtools.DebuggerAgent.prototype.didIsProfilingStarted_ = function(
     is_started) {
-  if (is_started) {
+  if (is_started && !this.isProfilingStarted_) {
     // Start to query log data.
     RemoteDebuggerAgent.GetLogLines(this.lastProfileLogPosition_);
   }
+  this.isProfilingStarted_ = is_started;
+  // Update button.
   WebInspector.setRecordingProfile(is_started);
+  if (is_started) {
+    // Monitor profiler state. It can stop itself on buffer fill-up.
+    setTimeout(function() { RemoteDebuggerAgent.IsProfilingStarted(); }, 1000);
+  }
 };
 
 
 /**
  * Handles a portion of a profiler log retrieved by GetLogLines call.
  * @param {string} log A portion of profiler log.
  * @param {number} newPosition The position in log file to read from
  *     next time.
  */
 devtools.DebuggerAgent.prototype.didGetLogLines_ = function(
     log, newPosition) {
   if (log.length > 0) {
     this.profilerProcessor_.processLogChunk(log);
     this.lastProfileLogPosition_ = newPosition;
-  } else if (this.isProcessingProfile_) {
-    this.isProcessingProfile_ = false;
-    WebInspector.setRecordingProfile(false);
-    WebInspector.addProfile(this.profilerProcessor_.createProfileForView());
+  } else if (!this.isProfilingStarted_) {
+    // No new data and profiling is stopped---suspend log reading.
     return;
   }
-  setTimeout(function() { RemoteDebuggerAgent.GetLogLines(newPosition); },
-    this.isProcessingProfile_ ? 100 : 1000);
+  setTimeout(function() { RemoteDebuggerAgent.GetLogLines(newPosition); }, 500);
 };
 
 
 /**
  * Adds the script info to the local cache. This method assumes that the script
  * is not in the cache yet.
  * @param {Object} script Script json object from the debugger message.
  */
 devtools.DebuggerAgent.prototype.addScriptInfo_ = function(script) {
   this.parsedScripts_[script.id] = new devtools.ScriptInfo(
@@ skipping 502 matching lines @@
 
 
 /**
  * @param {number} handle Object handle.
  * @return {?Object} Returns the object with the handle if it was sent in this
  *    message(some objects referenced by handles may be missing in the message).
  */
 devtools.DebuggerMessage.prototype.lookup = function(handle) {
   return this.refs_[handle];
 };