Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 11395: Removed all functions for parsing the debugger command line commands. The cor... (Closed)

Created:
12 years, 1 month ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Removed all functions for parsing the debugger command line commands. The core debugger should only support the JSON protocol. Expect these functions to re-appear in d8. Added processDebugRequest to the debugger which will only process a JSON request. Use that function in the debugger. Committed: http://code.google.com/p/v8/source/detail?r=824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -342 lines) Patch
M src/debug.cc View 2 chunks +29 lines, -27 lines 2 comments Download
M src/debug-delay.js View 1 chunk +4 lines, -315 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
12 years, 1 month ago (2008-11-24 08:36:47 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/11395/diff/1/2 File src/debug.cc (right): http://codereview.chromium.org/11395/diff/1/2#newcode1816 Line 1816: const int kArgc = 1; Do you ...
12 years, 1 month ago (2008-11-24 08:46:31 UTC) #2
Søren Thygesen Gjesse
12 years, 1 month ago (2008-11-24 10:31:47 UTC) #3
http://codereview.chromium.org/11395/diff/1/2
File src/debug.cc (right):

http://codereview.chromium.org/11395/diff/1/2#newcode1816
Line 1816: const int kArgc = 1;
On 2008/11/24 08:46:31, Mads Ager wrote:
> Do you want this to be static as well?

Sure, changed.

Powered by Google App Engine
This is Rietveld 408576698