Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 113945: Headers cleanup in chrome/common (Closed)

Created:
11 years, 7 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Headers cleanup in chrome/common - reduce header dependencies - miscellanous cleanups (whitespace, explicit deps) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17177

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M chrome/browser/dom_ui/history_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/url_database.h View 1 chunk +2 lines, -0 lines 1 comment Download
M chrome/common/child_process.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/child_process.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/child_process_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/child_thread.h View 1 chunk +1 line, -0 lines 1 comment Download
M chrome/common/extensions/extension.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_error_reporter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_error_reporter.cc View 1 chunk +4 lines, -0 lines 1 comment Download
M chrome/common/ipc_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ipc_logging.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/ipc_sync_channel.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/common/jstemplate_builder.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/mru_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/cookie_monster_sqlite.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/net/url_request_intercept_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/page_action.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/resource_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/sqlite_compiled_statement.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/sqlite_compiled_statement.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
Recently Visual Studio started to like rebuilding V8 bindings on my Windows machine. I don't ...
11 years, 7 months ago (2009-05-28 09:21:52 UTC) #1
Dean McNamee
11 years, 7 months ago (2009-05-28 09:27:18 UTC) #2
Millions of bonus points for header cleanup.

LGTM, a few tiny nits, you can ignore them if you want.

Make sure you don't break the release build :\

Thanks!

http://codereview.chromium.org/113945/diff/1/3
File chrome/browser/history/url_database.h (right):

http://codereview.chromium.org/113945/diff/1/3#newcode15
Line 15: #include "chrome/common/sqlite_utils.h"
If this is in the "temporary" category the newline before it should be removed. 
Otherwise it should go w/ the rest of the headers.

http://codereview.chromium.org/113945/diff/1/7
File chrome/common/child_thread.h (right):

http://codereview.chromium.org/113945/diff/1/7#newcode89
Line 89: DISALLOW_EVIL_CONSTRUCTORS(ChildThread);
maybe update this?  And we should include basictypes.h?

http://codereview.chromium.org/113945/diff/1/9
File chrome/common/extensions/extension_error_reporter.cc (right):

http://codereview.chromium.org/113945/diff/1/9#newcode7
Line 7: #include "build/build_config.h"
heh

Powered by Google App Engine
This is Rietveld 408576698