Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_config.cc

Issue 113944: Use the new CanonicalizeHostVerbose() function. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: is_valid -> is_nonempty Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/registry_controlled_domain.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config.cc
===================================================================
--- net/proxy/proxy_config.cc (revision 19036)
+++ net/proxy/proxy_config.cc (working copy)
@@ -97,11 +97,11 @@
bool IsIPAddress(const std::string& domain) {
// From GURL::HostIsIPAddress()
url_canon::RawCanonOutputT<char, 128> ignored_output;
- url_parse::Component ignored_component;
+ url_canon::CanonHostInfo host_info;
url_parse::Component domain_comp(0, domain.size());
- return url_canon::CanonicalizeIPAddress(domain.c_str(), domain_comp,
- &ignored_output,
- &ignored_component);
+ url_canon::CanonicalizeIPAddress(domain.c_str(), domain_comp,
+ &ignored_output, &host_info);
+ return host_info.IsIPAddress();
}
} // namespace
« no previous file with comments | « net/base/registry_controlled_domain.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698