Linux Breakpad tweaking to get symbols working....

Linux Breakpad tweaking to get symbols working.

Do endian swapping for the identifier in dump_syms.
Fill in the pdb_file_name (debug_file) field for modules.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17081

[Lei Zhang, 2009-05-28 08:34:30]

Wee!

http://codereview.chromium.org/113943/diff/1/3
File breakpad/linux/minidump_writer.cc (left):

http://codereview.chromium.org/113943/diff/1/3#oldcode515
Line 515: UntypedMDRVA memory(&minidump_writer_);
Unused.

http://codereview.chromium.org/113943/diff/1/3#oldcode518
Line 518: TypedMDRVA<MDCVInfoPDB70> cv(&minidump_writer_);
This wasn't working out. Even if I allocated the right amount of space, the
file_pdb_name field would always somehow get zeroed-out.

http://codereview.chromium.org/113943/diff/1/3#oldcode542
Line 542: if (filename_len) {
ShouldIncludeMapping() would have skipped any files with no file name.

[agl, 2009-05-28 16:51:51]

LGTM

http://codereview.chromium.org/113943/diff/1/3
File breakpad/linux/minidump_writer.cc (right):

http://codereview.chromium.org/113943/diff/1/3#newcode518
Line 518: char* filename_ptr = const_cast<char*>(mapping.name) + filepath_len -
1;
Rather than const_casting to a char*, I think you can just make that a const
char*.

[Lei Zhang, 2009-05-28 17:57:30]

http://codereview.chromium.org/113943/diff/1/3
File breakpad/linux/minidump_writer.cc (right):

http://codereview.chromium.org/113943/diff/1/3#newcode518
Line 518: char* filename_ptr = const_cast<char*>(mapping.name) + filepath_len -
1;
On 2009/05/28 16:51:51, agl wrote:
> Rather than const_casting to a char*, I think you can just make that a const
> char*.

Done,