Make Textfield more portable....

Make Textfield more portable.

Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface.

The APIs aren't perfectly tidy yet but this is a good first pass.

BUG=none
TEST=make sure you can still edit text fields, run the view unit tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17112

[sky, 2009-05-28 16:49:12]

http://codereview.chromium.org/113940/diff/1/2
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/113940/diff/1/2#newcode60
Line 60: : textfield_(textfield),
Order doesn't match of header.

http://codereview.chromium.org/113940/diff/1/2#newcode111
Line 111: l10n_util::GetString(IDS_APP_SELECT_ALL));
nit: line is too long.

http://codereview.chromium.org/113940/diff/1/2#newcode128
Line 128: delete this;
Should the delete this be outside of IsWindow() ?

http://codereview.chromium.org/113940/diff/1/4
File views/controls/textfield/native_textfield_wrapper.h (right):

http://codereview.chromium.org/113940/diff/1/4#newcode19
Line 19: virtual void Destroy() = 0;
Should we just use the destructor rather than a method?

http://codereview.chromium.org/113940/diff/1/5
File views/controls/textfield/textfield.cc (right):

http://codereview.chromium.org/113940/diff/1/5#newcode30
Line 30: use_default_background_color_(true),
What about initializing background_color_ here too?

http://codereview.chromium.org/113940/diff/1/6
File views/controls/textfield/textfield.h (right):

http://codereview.chromium.org/113940/diff/1/6#newcode100
Line 100: std::wstring text() const { return text_; }
const std::wstring&

http://codereview.chromium.org/113940/diff/1/6#newcode179
Line 179: virtual void SetEnabled(bool enabled);
nit: newline after this.

[Ben Goodger (Google), 2009-05-28 20:46:56]

Updated. Please take another look.

[sky, 2009-05-28 20:52:03]

LGTM