Issue 113933: Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles().

Issue 113933: Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles(). (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles(). Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17091

Patch Set 1 #

Patch Set 2 : Stop using return InputApi._RightHandSideLinesImpl( #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -20 lines)			Patch
	M	presubmit_support.py	View	1	12 chunks	+40 lines, -12 lines	1 comment	Download
	M	tests/presubmit_unittest.py	View		7 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

http://codereview.chromium.org/113933/diff/4/1003 File presubmit_support.py (right): http://codereview.chromium.org/113933/diff/4/1003#newcode196 Line 196: def DepotToLocalPath(self, depot_path): why make non-static when it ...

11 years, 7 months ago (2009-05-28 16:49:35 UTC) #2

M-A Ruel

On 2009/05/28 16:49:35, Jói wrote: > http://codereview.chromium.org/113933/diff/4/1003 > File presubmit_support.py (right): > > http://codereview.chromium.org/113933/diff/4/1003#newcode196 > ...

11 years, 7 months ago (2009-05-28 17:03:55 UTC) #3

Jói Sigurðsson

LGTM No, that's fine, leave it in this change, maybe just update the comment to ...

11 years, 7 months ago (2009-05-28 18:03:42 UTC) #4

Jói Sigurðsson

11 years, 7 months ago (2009-05-28 18:04:00 UTC) #5

LGTM

Sorry, I meant update the change description, not the comment in the code.

On 2009/05/28 18:03:42, Jói wrote:
> LGTM
> 
> No, that's fine, leave it in this change, maybe just update the comment to
> explain why.
> 
> On 2009/05/28 17:03:55, M-A wrote:
> > On 2009/05/28 16:49:35, Jói wrote:
> > > http://codereview.chromium.org/113933/diff/4/1003
> > > File presubmit_support.py (right):
> > > 
> > > http://codereview.chromium.org/113933/diff/4/1003#newcode196
> > > Line 196: def DepotToLocalPath(self, depot_path):
> > > why make non-static when it doesn't use self?
> > 
> > It's for a subsequent change, since I need to factor out it's SCM. I can
> remove
> > this change meanwhile.

Expand Messages | Collapse Messages