Issue 113932: Clean-up of the app modal dialog queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113932: Clean-up of the app modal dialog queue (Closed)

Created:
11 years, 7 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL is a clean-up of the app_modal_dialog_queue.cc in an attempt to fix a bug 10699. Not sure what is causing the crasher. Hopefully after this clean-up we'll get a different stack-trace that might help. BUG=10699 TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17078

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -48 lines)			Patch
M	chrome/browser/app_modal_dialog.cc	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/app_modal_dialog_queue.h	View		3 chunks	+16 lines, -8 lines	0 comments	Download
M	chrome/browser/app_modal_dialog_queue.cc	View		1 chunk	+11 lines, -28 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/jsmessage_box_handler.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages