Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 113931: Remove code path that passes a file handle to the renderer... (Closed)

Created:
11 years, 7 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove code path that passes a file handle to the renderer Since the code now does range request without any caching the code path for passing file handle is not used any more. Changes: 1. Remove response_data_file in webkit_glue::ResourceResponseHead 2. Remove response_data_file in net::ResourceInfo 3. Remove code that passes file handle using IPC 4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost 5. Remove MediaResourceHandler 6. Remove code in disk_cache that expose the file handle 7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used 8. Reset cache size for media cache to default BUG=12249 BUG=12256 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17227

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -659 lines) Patch
M chrome/browser/browser.vcproj View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/profile.cc View 1 2 3 4 5 6 7 8 9 4 chunks +2 lines, -25 lines 0 comments Download
D chrome/browser/renderer_host/media_resource_handler.h View 1 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/renderer_host/media_resource_handler.cc View 1 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 4 5 5 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/resource_dispatcher.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 1 2 3 chunks +0 lines, -25 lines 0 comments Download
M net/base/cache_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/load_flags.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M net/disk_cache/disk_cache.h View 2 chunks +0 lines, -23 lines 0 comments Download
M net/disk_cache/entry_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 4 chunks +1 line, -50 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M net/disk_cache/histogram_macros.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/disk_cache/mem_entry_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/http/http_cache.cc View 3 chunks +0 lines, -31 lines 0 comments Download
M net/http/http_cache_unittest.cc View 5 chunks +2 lines, -96 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_response_info.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/http/http_response_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 2 3 4 2 chunks +0 lines, -21 lines 0 comments Download
M webkit/glue/resource_loader_bridge.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scherkus (not reviewing)
Haven't looked at any of the code yet, but I believe the preferred bug format ...
11 years, 7 months ago (2009-05-28 01:27:51 UTC) #1
Alpha Left Google
On 2009/05/28 01:27:51, scherkus wrote: > Haven't looked at any of the code yet, but ...
11 years, 7 months ago (2009-05-28 05:35:12 UTC) #2
Alpha Left Google
removed the code path that passes the file handle to the renderer, so the changes ...
11 years, 7 months ago (2009-05-28 18:33:35 UTC) #3
Alpha Left Google
Remove most of the code path but preserved the request context for media so there ...
11 years, 7 months ago (2009-05-28 22:14:43 UTC) #4
rvargas (doing something else)
11 years, 6 months ago (2009-05-29 02:50:43 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698