Issue 113930: Disk cache: Reset mask_ when the disk cache is being restarted....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113930: Disk cache: Reset mask_ when the disk cache is being restarted.... (Closed)

Created:
11 years, 7 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Reset mask_ when the disk cache is being restarted. It is possible that the size for the index table is reduced when the cache is restarted (the available disk space could be lower than what it was when the cache was originally created). If that is the case, not resetting mask_ to 0 will prevent the mask to be set correctly for the new table size, resulting in a crash. BUG=12378 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17052

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -0 lines)			Patch
A	net/data/cache_tests/bad_rankings2/contents.txt	View	1 chunk	+66 lines, -0 lines	0 comments	Download
A	net/data/cache_tests/bad_rankings2/data_0	View	Binary file		0 comments	Download
A	net/data/cache_tests/bad_rankings2/data_1	View	Binary file		0 comments	Download
A	net/data/cache_tests/bad_rankings2/data_2	View	Binary file		0 comments	Download
A	net/data/cache_tests/bad_rankings2/data_3	View	Binary file		0 comments	Download
A	net/data/cache_tests/bad_rankings2/index	View	Binary file		0 comments	Download
M	net/disk_cache/backend_impl.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	net/disk_cache/backend_unittest.cc	View	3 chunks	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages