Issue 113923: Change default audio device from "plug:default" to "default".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113923: Change default audio device from "plug:default" to "default". (Closed)

Created:
11 years, 7 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing), Alpha Left Google

CC:
chromium-reviews_googlegroups.com, fbarchard

Visibility:
Public.

Description

Change default audio device from "plug:default" to "default".

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 1

Patch Set 3 : Capitlizing PCM, just for scherkus. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
M	media/audio/linux/alsa_output.h	View	2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	media/audio/linux/alsa_output.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/linux/audio_manager_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

Think you missed one instance: media/audio/linux/alsa_output.h 46: // Set to "plug:default" which should allow ALSA ...

11 years, 7 months ago (2009-05-27 22:33:16 UTC) #2

scherkus (not reviewing)

11 years, 7 months ago (2009-05-27 22:51:08 UTC) #4

LGTM with one nit

http://codereview.chromium.org/113923/diff/1004/5
File media/audio/linux/alsa_output.h (right):

http://codereview.chromium.org/113923/diff/1004/5#newcode47
Line 47: // ALSA to multiplex sound from different processes that want to write
pcm
nit: pcm -> PCM ;)

Expand Messages | Collapse Messages