Make sure that we're restoring focus to a valid subview. (with Rohit)...

Make sure that we're restoring focus to a valid subview. (with Rohit)

BUG=http://crbug.com/12725

TEST=repro test mentioned in http://code.google.com/p/chromium/issues/detail?id=12725#c4


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17027

[Avi (use Gerrit), 2009-05-27 21:37:14]

Jeremy: you're in, take a look
Pink: your idea, but you're out for the day

[jeremy, 2009-05-27 21:38:30]

LGTM

[pink (ping after 24hrs), 2009-05-28 12:35:23]

http://codereview.chromium.org/113922/diff/6/1002
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/113922/diff/6/1002#newcode458
Line 458: if (![self superview]) {
I usually check [self window] when determining if I'm in the view hierarchy or
not, since you could have a parent (maybe a NSScrollView or something) but still
be dying. We know a little better in this case, but it still pays to be safe in
case our hierarchy changes, no?

[Avi (use Gerrit), 2009-05-28 13:52:04]

It's part of our basic architecture that RWHV lives in TCV. I'm not worried
about this now.