Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113920: Dangerous download dialog for linux.... (Closed)

Created:
11 years, 7 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Dangerous download dialog for linux. BUG=11780 TEST=go to cygwin.com, click "install or update now". The download shelf should appear with a dangerous download dialog, which should animate properly and without undue jank. Clicking "cancel" should delete the item and hide the shelf (since it's the only thing in the shelf). Clicking "save" should make it become a normal download item. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17041

Patch Set 1 #

Patch Set 2 : sync #

Total comments: 1

Patch Set 3 : mac uses DownloadManager? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -38 lines) Patch
M chrome/browser/download/download_exe.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 2 3 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/download/download_util.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.h View 1 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 1 15 chunks +166 lines, -17 lines 0 comments Download
M chrome/browser/gtk/download_shelf_gtk.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
chrome/browser/gtk/infobar_gtk.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/slide_animator_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
11 years, 7 months ago (2009-05-27 20:39:14 UTC) #1
Evan Stade
added Evan and Lei. suggested division of labor: Elliot: gtk Evan/Lei: browser/download/*
11 years, 7 months ago (2009-05-27 20:41:08 UTC) #2
Elliot Glaysher
GTK parts: LGTM. http://codereview.chromium.org/113920/diff/2001/2007 File chrome/browser/download/download_exe.cc (right): http://codereview.chromium.org/113920/diff/2001/2007#newcode146 Line 146: "sh", Some quick additions off ...
11 years, 7 months ago (2009-05-27 20:53:33 UTC) #3
Lei Zhang
11 years, 7 months ago (2009-05-27 20:59:36 UTC) #4 
non-GTK parts: LGTM

Powered by Google App Engine
This is Rietveld 408576698