Issue 113907: Let ChromiumBridge::paintTextField check if the Color object passed in is val...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113907: Let ChromiumBridge::paintTextField check if the Color object passed in is val... (Closed)

Created:
11 years, 7 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Let ChromiumBridge::paintTextField check if the Color object passed in is valid or not. If not valid, just pass white to ThemeEngine. This change was motivated by the issue http://code.google.com/p/chromium/issues/detail?id=2756, but it has been resolved by only the upstream change https://bugs.webkit.org/show_bug.cgi?id=25742. However, this verification code is still useful. BUG=2756 Checked in for tyoshino@google.com Original review: http://codereview.chromium.org/113165 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17001

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	webkit/api/src/ChromiumBridge.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download