Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: chrome/browser/views/bookmark_manager_view.cc

Issue 113901: Reverting 16982. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/views/bookmark_manager_view.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/bookmark_manager_view.h" 5 #include "chrome/browser/views/bookmark_manager_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "app/gfx/canvas.h" 9 #include "app/gfx/canvas.h"
10 #include "app/gfx/color_utils.h" 10 #include "app/gfx/color_utils.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 layout->AddView(tools_menu_button); 199 layout->AddView(tools_menu_button);
200 layout->AddView(new views::Label( 200 layout->AddView(new views::Label(
201 l10n_util::GetString(IDS_BOOKMARK_MANAGER_SEARCH_TITLE))); 201 l10n_util::GetString(IDS_BOOKMARK_MANAGER_SEARCH_TITLE)));
202 layout->AddView(search_tf_); 202 layout->AddView(search_tf_);
203 203
204 layout->AddPaddingRow(0, 3); // 3px padding between rows. 204 layout->AddPaddingRow(0, 3); // 3px padding between rows.
205 205
206 layout->StartRow(1, split_cs_id); 206 layout->StartRow(1, split_cs_id);
207 layout->AddView(split_view_); 207 layout->AddView(split_view_);
208 208
209 // Press Ctrl-W to close bookmark manager window.
210 AddAccelerator(views::Accelerator('W', false, true, false));
211
212 BookmarkModel* bookmark_model = profile_->GetBookmarkModel(); 209 BookmarkModel* bookmark_model = profile_->GetBookmarkModel();
213 if (!bookmark_model->IsLoaded()) 210 if (!bookmark_model->IsLoaded())
214 bookmark_model->AddObserver(this); 211 bookmark_model->AddObserver(this);
215 } 212 }
216 213
217 BookmarkManagerView::~BookmarkManagerView() { 214 BookmarkManagerView::~BookmarkManagerView() {
218 if (select_file_dialog_.get()) 215 if (select_file_dialog_.get())
219 select_file_dialog_->ListenerDestroyed(); 216 select_file_dialog_->ListenerDestroyed();
220 217
221 if (!GetBookmarkModel()->IsLoaded()) { 218 if (!GetBookmarkModel()->IsLoaded()) {
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 333
337 std::wstring BookmarkManagerView::GetWindowName() const { 334 std::wstring BookmarkManagerView::GetWindowName() const {
338 return prefs::kBookmarkManagerPlacement; 335 return prefs::kBookmarkManagerPlacement;
339 } 336 }
340 337
341 void BookmarkManagerView::WindowClosing() { 338 void BookmarkManagerView::WindowClosing() {
342 g_browser_process->local_state()->SetInteger( 339 g_browser_process->local_state()->SetInteger(
343 prefs::kBookmarkManagerSplitLocation, split_view_->divider_x()); 340 prefs::kBookmarkManagerSplitLocation, split_view_->divider_x());
344 } 341 }
345 342
346 bool BookmarkManagerView::AcceleratorPressed(
347 const views::Accelerator& accelerator) {
348 // Ctrl-W to close bookmark manager.
349 DCHECK(accelerator.GetKeyCode() == 'W' && accelerator.IsCtrlDown());
350 window()->Close();
351 return true;
352 }
353
354 void BookmarkManagerView::OnDoubleClick() { 343 void BookmarkManagerView::OnDoubleClick() {
355 std::vector<BookmarkNode*> nodes = GetSelectedTableNodes(); 344 std::vector<BookmarkNode*> nodes = GetSelectedTableNodes();
356 if (nodes.empty()) 345 if (nodes.empty())
357 return; 346 return;
358 if (nodes.size() == 1 && nodes[0]->is_folder()) { 347 if (nodes.size() == 1 && nodes[0]->is_folder()) {
359 // Double click on a folder descends into the folder. 348 // Double click on a folder descends into the folder.
360 SelectInTree(nodes[0]); 349 SelectInTree(nodes[0]);
361 return; 350 return;
362 } 351 }
363 // TODO(sky): OnDoubleClick needs a handle to the current mouse event so that 352 // TODO(sky): OnDoubleClick needs a handle to the current mouse event so that
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
768 file_type_info.extensions.resize(1); 757 file_type_info.extensions.resize(1);
769 file_type_info.extensions[0].push_back(FILE_PATH_LITERAL("html")); 758 file_type_info.extensions[0].push_back(FILE_PATH_LITERAL("html"));
770 file_type_info.include_all_files = true; 759 file_type_info.include_all_files = true;
771 select_file_dialog_ = SelectFileDialog::Create(this); 760 select_file_dialog_ = SelectFileDialog::Create(this);
772 select_file_dialog_->SelectFile( 761 select_file_dialog_->SelectFile(
773 SelectFileDialog::SELECT_SAVEAS_FILE, std::wstring(), 762 SelectFileDialog::SELECT_SAVEAS_FILE, std::wstring(),
774 FilePath(FILE_PATH_LITERAL("bookmarks.html")), &file_type_info, 0, 763 FilePath(FILE_PATH_LITERAL("bookmarks.html")), &file_type_info, 0,
775 L"html", GetWidget()->GetNativeView(), 764 L"html", GetWidget()->GetNativeView(),
776 reinterpret_cast<void*>(IDS_BOOKMARK_MANAGER_EXPORT_MENU)); 765 reinterpret_cast<void*>(IDS_BOOKMARK_MANAGER_EXPORT_MENU));
777 } 766 }
OLDNEW
« no previous file with comments | « chrome/browser/views/bookmark_manager_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698