Issue 113899: Starts converting GclChange to a method-less class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113899: Starts converting GclChange to a method-less class. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Make the member variable 'protected' in the python sense. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17039

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -23 lines)			Patch
	M	presubmit_support.py	View	1 2	5 chunks	+29 lines, -22 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

M-A Ruel

I haven't updated the unit tests yet because I want to have your opinion first ...

11 years, 7 months ago (2009-05-27 15:09:05 UTC) #1

Jói Sigurðsson

11 years, 7 months ago (2009-05-27 16:01:47 UTC) #3

LGTM
cool, thanks - those definitely should have been private from the start