Issue 113894: Added stack overflow check for RegExp analysis phase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113894: Added stack overflow check for RegExp analysis phase. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Added stack overflow check for RegExp analysis phase. A very long regexp graph can overflow the stack with recursive calls.

Patch Set 1 #

Patch Set 2 : Added test for stack overflow #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -6 lines)			Patch
M	src/jsregexp.h	View	2 chunks	+10 lines, -1 line	1 comment	Download
M	src/jsregexp.cc	View	5 chunks	+22 lines, -5 lines	0 comments	Download
M	test/mjsunit/regexp.js	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 7 months ago (2009-05-27 10:04:48 UTC) #2

Lgtm

http://codereview.chromium.org/113894/diff/1001/1003
File src/jsregexp.h (right):

http://codereview.chromium.org/113894/diff/1001/1003#newcode1322
Line 1322: bool failed() { return error_message_ != NULL; }
Since this is a boolean predicate it should be 'has_failed'.

Expand Messages | Collapse Messages