Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 113890: Chrome renderer support for YV16. (Closed)

Created:
11 years, 7 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chrome renderer support for YV16. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17016

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/renderer/media/video_renderer_impl.cc View 1 2 6 chunks +17 lines, -11 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
fbarchard
YV16 support for jpg and high profile mp4.
11 years, 7 months ago (2009-05-27 06:08:55 UTC) #1
fbarchard
YV16 for JPG and high profile mp4.
11 years, 7 months ago (2009-05-27 06:09:43 UTC) #2
Alpha Left Google
LGTM with two style nits. http://codereview.chromium.org/113890/diff/4/5 File chrome/renderer/media/video_renderer_impl.cc (right): http://codereview.chromium.org/113890/diff/4/5#newcode119 Line 119: media::YV12 : media::YV16; ...
11 years, 7 months ago (2009-05-27 20:11:10 UTC) #3
fbarchard
done http://codereview.chromium.org/113890/diff/4/5 File chrome/renderer/media/video_renderer_impl.cc (right): http://codereview.chromium.org/113890/diff/4/5#newcode119 Line 119: media::YV12 : media::YV16; On 2009/05/27 20:11:10, Alpha ...
11 years, 7 months ago (2009-05-27 20:15:10 UTC) #4
scherkus (not reviewing)
http://codereview.chromium.org/113890/diff/9/1003 File chrome/renderer/media/video_renderer_impl.cc (right): http://codereview.chromium.org/113890/diff/9/1003#newcode162 Line 162: media::YUVType yuv_type = (frame_in.format == media::VideoSurface::YV12) ? we ...
11 years, 7 months ago (2009-05-28 01:35:15 UTC) #5
fbarchard
11 years, 7 months ago (2009-05-28 02:23:32 UTC) #6
is that a lgtm?

http://codereview.chromium.org/113890/diff/9/1003
File chrome/renderer/media/video_renderer_impl.cc (right):

http://codereview.chromium.org/113890/diff/9/1003#newcode162
Line 162: media::YUVType yuv_type = (frame_in.format ==
media::VideoSurface::YV12) ?
it does stand out as weird.
My longer term plan is a high level yuv scaler with clipping that takes any
VideoSurface and converts/scales/clips/rotates to a 32 bit canvas.  With only 2
formats, its not that interesting.  It'll also be more interesting to have a
smart clipper when we do rotation/mirroring in chrome.

Powered by Google App Engine
This is Rietveld 408576698