Chrome renderer support for YV16.

Chrome renderer support for YV16.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17016

[fbarchard, 2009-05-27 06:08:55]

YV16 support for jpg and high profile mp4.

[fbarchard, 2009-05-27 06:09:43]

YV16 for JPG and high profile mp4.

[Alpha Left Google, 2009-05-27 20:11:10]

LGTM with two style nits.

http://codereview.chromium.org/113890/diff/4/5
File chrome/renderer/media/video_renderer_impl.cc (right):

http://codereview.chromium.org/113890/diff/4/5#newcode119
Line 119: media::YV12 : media::YV16;
indent this line in parallel with previous line.

http://codereview.chromium.org/113890/diff/4/5#newcode163
Line 163: media::YV12 : media::YV16;
indent this line too.

[fbarchard, 2009-05-27 20:15:10]

done

http://codereview.chromium.org/113890/diff/4/5
File chrome/renderer/media/video_renderer_impl.cc (right):

http://codereview.chromium.org/113890/diff/4/5#newcode119
Line 119: media::YV12 : media::YV16;
On 2009/05/27 20:11:10, Alpha wrote:
> indent this line in parallel with previous line.

Done.

http://codereview.chromium.org/113890/diff/4/5#newcode163
Line 163: media::YV12 : media::YV16;
On 2009/05/27 20:11:10, Alpha wrote:
> indent this line too.

Done.

[scherkus (not reviewing), 2009-05-28 01:35:15]

http://codereview.chromium.org/113890/diff/9/1003
File chrome/renderer/media/video_renderer_impl.cc (right):

http://codereview.chromium.org/113890/diff/9/1003#newcode162
Line 162: media::YUVType yuv_type = (frame_in.format ==
media::VideoSurface::YV12) ?
we really should consider consolidating these two sets of enums -- I'll add it
to tracker

[fbarchard, 2009-05-28 02:23:32]

is that a lgtm?

http://codereview.chromium.org/113890/diff/9/1003
File chrome/renderer/media/video_renderer_impl.cc (right):

http://codereview.chromium.org/113890/diff/9/1003#newcode162
Line 162: media::YUVType yuv_type = (frame_in.format ==
media::VideoSurface::YV12) ?
it does stand out as weird.
My longer term plan is a high level yuv scaler with clipping that takes any
VideoSurface and converts/scales/clips/rotates to a 32 bit canvas.  With only 2
formats, its not that interesting.  It'll also be more interesting to have a
smart clipper when we do rotation/mirroring in chrome.