Issue 113884: Fix comparison in window_sizer_linux. There can be multiple desktops so data_...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113884: Fix comparison in window_sizer_linux. There can be multiple desktops so data_... (Closed)

Created:
11 years, 7 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix comparison in window_sizer_linux. There can be multiple desktops so data_len can be greater. TBR=evan BUG=none TEST=should work on window managers that support the wm-spec. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16970

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/window_sizer_linux.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I should've caught this in the review for your CL. :-\

11 years, 7 months ago (2009-05-27 03:08:41 UTC) #1

Evan Martin

11 years, 7 months ago (2009-05-27 05:48:09 UTC) #2

On 2009/05/27 03:08:41, Lei Zhang wrote:
> I should've caught this in the review for your CL. :-\

Bummer!  Can you fix the comment as well?  (E.g. "we expect at least one set of
four longs")

Expand Messages | Collapse Messages