Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: tests/presubmit_unittest.py

Issue 113883: Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index f50a0c59bdf17b54eddaf3f9e24007109783d8f9..e6d3d5ed895cfc0762c9b85ee43a220b26452a4c 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -116,7 +116,7 @@ class PresubmitUnittest(PresubmitTestsBase):
members = [
'AffectedFile', 'DoPresubmitChecks', 'GclChange', 'InputApi',
'ListRelevantPresubmitFiles', 'Main', 'NotImplementedException',
- 'OutputApi', 'ParseFiles', 'PresubmitExecuter', 'SPECIAL_KEYS',
+ 'OutputApi', 'ParseFiles', 'PresubmitExecuter',
'ScanSubDirs', 'SvnAffectedFile', 'cPickle', 'cStringIO', 'exceptions',
'fnmatch', 'gcl', 'gclient', 'glob', 'marshal', 'normpath', 'optparse',
'os', 'pickle', 'presubmit_canned_checks', 're', 'subprocess', 'sys',
@@ -162,13 +162,11 @@ class PresubmitUnittest(PresubmitTestsBase):
change = presubmit.GclChange(ci)
self.failUnless(change.Change() == 'mychange')
- self.failUnless(change.Changelist() == 'mychange')
self.failUnless(change.DescriptionText() ==
'Hello there\nthis is a change\nand some more regular text')
self.failUnless(change.FullDescriptionText() ==
'\n'.join(description_lines))
- self.failUnless(change.BugIDs == '123')
self.failUnless(change.BUG == '123')
self.failUnless(change.STORY == 'http://foo/')
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698