Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 113882: Add a preference to enable/disable ID persistence in bookmark model and... (Closed)

Created:
11 years, 7 months ago by Munjal (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, tim (not reviewing), ncarter (slow)
Visibility:
Public.

Description

Add a preference to enable/disable ID persistence in bookmark model and add methods in bookmark model to get/set this preference. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17017

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M chrome/browser/bookmarks/bookmark_model.h View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 2 6 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 1 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Munjal (Google)
11 years, 7 months ago (2009-05-27 01:37:26 UTC) #1
sky
http://codereview.chromium.org/113882/diff/1/2 File chrome/browser/bookmarks/bookmark_model.cc (right): http://codereview.chromium.org/113882/diff/1/2#newcode59 Line 59: const wchar_t kPrefPersistIDs[] = L"bookmarks.persist_ids"; nit: don't indent ...
11 years, 7 months ago (2009-05-27 14:44:24 UTC) #2
Munjal (Google)
http://codereview.chromium.org/113882/diff/1/2 File chrome/browser/bookmarks/bookmark_model.cc (right): http://codereview.chromium.org/113882/diff/1/2#newcode59 Line 59: const wchar_t kPrefPersistIDs[] = L"bookmarks.persist_ids"; On 2009/05/27 14:44:24, ...
11 years, 7 months ago (2009-05-27 19:19:33 UTC) #3
sky
LGTM with the following change. http://codereview.chromium.org/113882/diff/1002/12 File chrome/browser/bookmarks/bookmark_model.cc (right): http://codereview.chromium.org/113882/diff/1002/12#newcode388 Line 388: return persist_ids_; You ...
11 years, 7 months ago (2009-05-27 19:34:51 UTC) #4
Munjal (Google)
11 years, 7 months ago (2009-05-27 20:00:05 UTC) #5
http://codereview.chromium.org/113882/diff/1002/12
File chrome/browser/bookmarks/bookmark_model.cc (right):

http://codereview.chromium.org/113882/diff/1002/12#newcode388
Line 388: return persist_ids_;
On 2009/05/27 19:34:51, sky wrote:
> You may as well put this in the and inline it now that it's trivial.

Done.

Powered by Google App Engine
This is Rietveld 408576698