Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 113877: linux: fix CHECK fail in window_sizer. (Closed)

Created:
11 years, 7 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: fix CHECK fail in window_sizer. 1) We shouldn't use CHECK for situations that can reasonably occur. 2) We need to recover from the case where this WORKAREA property isn't available.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M chrome/browser/window_sizer_linux.cc View 2 chunks +37 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
11 years, 7 months ago (2009-05-26 23:55:39 UTC) #1
tony
LGTM.
11 years, 7 months ago (2009-05-26 23:57:58 UTC) #2
Lei Zhang
11 years, 7 months ago (2009-05-26 23:58:41 UTC) #3
+1

Powered by Google App Engine
This is Rietveld 408576698