Issue 113876: Fix breakpad-related Linux official build breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113876: Fix breakpad-related Linux official build breakage. (Closed)

Created:
11 years, 7 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
jon, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix breakpad-related Linux official build breakage. This fixes the following errors when building unit_tests: undefined reference to `google_breakpad::WriteMinidump(char const*, int, void const*, unsigned int)' undefined reference to `UploadCrashDump(char const*, char const*, unsigned int)'

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix ret val #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/app/breakpad_linux_stub.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/chrome.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 7 months ago (2009-05-26 23:49:11 UTC) #2

LGTM with nit below. Also, please note that it's just to get unit_tests to build
in the description.

http://codereview.chromium.org/113876/diff/1/2
File chrome/app/breakpad_linux_stub.cc (right):

http://codereview.chromium.org/113876/diff/1/2#newcode13
Line 13: return 0;
Should be -1.

Expand Messages | Collapse Messages