Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 113875: Linux: Breakpad updates. (Closed)

Created:
11 years, 7 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: Breakpad updates. The crash server requires an MDRawSystemInfo stream in order to process the file, although it actually only needs a single value in it. Additionally, it needs a PDB7 structure for each module, so we remove those modules which probably aren't shared libraries and XOR the first page of data to get a signature for them. The previous code opened the file and MD5 summed the text segment. However, we can't know if the shared library is still linked on disk, nor if the whole text segment is mapped in memory. Thus, we only assume that a single page is mapped. dump_syms will need to be forked and updated to match the signature scheme used in this patch. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17030

Patch Set 1 #

Total comments: 1

Patch Set 2 : ... #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -19 lines) Patch
M breakpad/linux/linux_dumper.h View 1 chunk +1 line, -0 lines 0 comments Download
M breakpad/linux/linux_dumper.cc View 1 chunk +17 lines, -14 lines 0 comments Download
M breakpad/linux/minidump_writer.cc View 1 6 chunks +72 lines, -5 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
agl
11 years, 7 months ago (2009-05-26 23:39:13 UTC) #1
Lei Zhang
LGTM http://codereview.chromium.org/113875/diff/1/4 File breakpad/linux/minidump_writer.cc (right): http://codereview.chromium.org/113875/diff/1/4#newcode508 Line 508: continue; Can we put this and the ...
11 years, 7 months ago (2009-05-27 00:06:19 UTC) #2
Lei Zhang
11 years, 7 months ago (2009-05-27 07:10:55 UTC) #3
LGTM

http://codereview.chromium.org/113875/diff/1007/7
File breakpad/linux/minidump_writer.cc (right):

http://codereview.chromium.org/113875/diff/1007/7#newcode477
Line 477: mapping.size < 4096) { // too small to get a signature for.
style nit: two space before //

Powered by Google App Engine
This is Rietveld 408576698