Fix a browser crash that occurs if the extension unpacker process crashes...

Fix a browser crash that occurs if the extension unpacker process crashes
after it sends a response to the browser.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17222

[Erik does not do reviews, 2009-05-26 23:55:50]

http://codereview.chromium.org/113867/diff/1/2
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/113867/diff/1/2#newcode101
Line 101: expected_id_(expected_id), from_external_(from_external) {
initialize got_response_ to false

http://codereview.chromium.org/113867/diff/1/2#newcode150
Line 150: OnUnpackExtensionFailed("Chrome crashed while trying to install.");
I'm not sure how this message gets relayed.  Could it be racey?  In other words,
could the unpack message be in a message queue waiting to be delivered when we
process this?

http://codereview.chromium.org/113867/diff/1/2#newcode418
Line 418: if (extension_id == kUnpackExtensionDir)
how could this be true?  please add a comment.

[Matt Perry, 2009-05-27 00:20:40]

http://codereview.chromium.org/113867/diff/1/2
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/113867/diff/1/2#newcode101
Line 101: expected_id_(expected_id), from_external_(from_external) {
On 2009/05/26 23:55:51, Erik Kay wrote:
> initialize got_response_ to false

Done.

http://codereview.chromium.org/113867/diff/1/2#newcode150
Line 150: OnUnpackExtensionFailed("Chrome crashed while trying to install.");
On 2009/05/26 23:55:51, Erik Kay wrote:
> I'm not sure how this message gets relayed.  Could it be racey?  In other
words,
> could the unpack message be in a message queue waiting to be delivered when we
> process this?

I'm not sure.  I don't think we'll get any messages after the process crashes,
but I added a check in Cleanup just to be safe.

http://codereview.chromium.org/113867/diff/1/2#newcode418
Line 418: if (extension_id == kUnpackExtensionDir)
On 2009/05/26 23:55:51, Erik Kay wrote:
> how could this be true?  please add a comment.

This was temporary code.  Removed.

[Erik does not do reviews, 2009-05-27 00:30:26]

LGTM